Tests and fixes for the exclusive SSO logistration view - #232
Merged
OmarIthawi merged 2 commits intoAug 3, 2018
Conversation
|
@OmarIthawi Why is the test labeled 'exclusive?' |
johnbaldwin
self-requested a review
April 17, 2018 14:32
OmarIthawi
changed the title
Author
|
@johnbaldwin thanks for the question. This is still work in progress. I'll clean it up and explain more. |
OmarIthawi
changed the title
OmarIthawi
changed the title
OmarIthawi
force-pushed
the
omar/exclusive-logistraion-tests
branch
from
April 23, 2018 13:18
307409e to
f037ea3
Compare
OmarIthawi
changed the title
Author
@johnbaldwin The feature name is |
OmarIthawi
changed the title
OmarIthawi
force-pushed
the
omar/exclusive-logistraion-tests
branch
from
July 30, 2018 14:33
f037ea3 to
d1f6435
Compare
OmarIthawi
changed the title
OmarIthawi
force-pushed
the
omar/exclusive-logistraion-tests
branch
2 times, most recently
from
August 2, 2018 06:19
41c88c1 to
5abae8c
Compare
OmarIthawi
force-pushed
the
omar/exclusive-logistraion-tests
branch
from
August 2, 2018 07:03
5abae8c to
7d52610
Compare
Author
|
@johnbaldwin After a long wait, I've got back to this. Please take a look if you'd like. |
Author
EXCLUSIVE_SSO_LOGISTRATION_URL_MAP
OmarIthawi
force-pushed
the
omar/exclusive-logistraion-tests
branch
from
August 3, 2018 07:49
7d52610 to
df68f04
Compare
thraxil
approved these changes
Aug 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up for #192.
TODO
EXCLUSIVE_SSO_LOGISTRATION_URL_MAPDisabled this feature. It's unused. Now both
loginandregisterare required